Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

In my opinion, when doing a code review over a weaker developer, as the stronger developer you should show your strength by making commits to help them improve their pull request, instead of passing back-and-forth a bunch of passive-aggressive comments. If you are reviewing someones work and you go back and forth more than a couple times, you should step in and pro-actively help resolve. Together as a team you draw the conclusion. NOT working as a team is a aspect of a Narcissist.


Definitely not; but, I would recommend, in the comment, to share alternative code and sample usage that they can take advantage of and apply themselves to their own code.

If you overwrite all their code, what have they learned?




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: